<html>
<head><meta charset="utf-8"><title>reviewing #73257 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/reviewing.20.2373257.html">reviewing #73257</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="200979259"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/reviewing%20%2373257/near/200979259" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/reviewing.20.2373257.html#200979259">(Jun 16 2020 at 07:02)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/73257">#73257</a> by <span class="user-mention silent" data-user-id="116107">davidtwco</span> fixes a <code>P-critical</code> issue and should be ready to land afaict.</p>
<p>I reviewed it myself but am unable to approve it, so it would be nice if someone else can also look over it and get it merged.</p>



<a name="200979318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/reviewing%20%2373257/near/200979318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/reviewing.20.2373257.html#200979318">(Jun 16 2020 at 07:03)</a>:</h4>
<p>it x4</p>



<a name="201308541"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/reviewing%20%2373257/near/201308541" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/reviewing.20.2373257.html#201308541">(Jun 18 2020 at 18:36)</a>:</h4>
<p>Afaict the failure in <a href="https://github.com/rust-lang/rust/pull/73257#issuecomment-646063479">https://github.com/rust-lang/rust/pull/73257#issuecomment-646063479</a> looks spurious, can someone retry?</p>



<a name="201315012"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/reviewing%20%2373257/near/201315012" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/reviewing.20.2373257.html#201315012">(Jun 18 2020 at 19:31)</a>:</h4>
<p>looking at it</p>



<a name="201315112"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/reviewing%20%2373257/near/201315112" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/reviewing.20.2373257.html#201315112">(Jun 18 2020 at 19:32)</a>:</h4>
<p>okay it's on the queue now</p>



<a name="201381499"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/reviewing%20%2373257/near/201381499" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/reviewing.20.2373257.html#201381499">(Jun 19 2020 at 12:16)</a>:</h4>
<p>can someone reapprove this again <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="201381648"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/reviewing%20%2373257/near/201381648" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/reviewing.20.2373257.html#201381648">(Jun 19 2020 at 12:18)</a>:</h4>
<p>thanks <span class="user-mention silent" data-user-id="211727">Jonas Schievink</span>  <span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>